Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gradle warnings in Dataflow test #747

Merged
merged 6 commits into from
May 22, 2024
Merged

Fix gradle warnings in Dataflow test #747

merged 6 commits into from
May 22, 2024

Conversation

Ao-senXiong
Copy link
Member

@Ao-senXiong Ao-senXiong commented Apr 24, 2024 •
edited

Fixes #742

@Ao-senXiong Ao-senXiong requested a review from wmdietl May 2, 2024 00:47
wmdietl
wmdietl requested changes May 21, 2024
View reviewed changes
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

dataflow/build.gradle Outdated Show resolved Hide resolved
dataflow/build.gradle Outdated Show resolved Hide resolved
@wmdietl wmdietl assigned Ao-senXiong and unassigned wmdietl May 21, 2024
@Ao-senXiong @wmdietl
Apply suggestions to code comment
e1ff069 
Co-authored-by: Werner Dietl <wdietl@gmail.com>
@Ao-senXiong Ao-senXiong requested a review from wmdietl May 21, 2024 23:19
@Ao-senXiong Ao-senXiong assigned wmdietl and unassigned Ao-senXiong May 21, 2024
wmdietl
wmdietl approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wmdietl wmdietl merged commit 5606690 into eisop:master May 22, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmdietl wmdietl wmdietl approved these changes

Assignees

@wmdietl wmdietl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataflow tests
2 participants
@Ao-senXiong @wmdietl