Fixed a bug in ArchiveExtractor that caused it to fail on case-insens… #843
Conversation
|
Thanks! Looks like this patch is needed by more people (#813) but the tests fail on Travis... could you see if you can figure out the reason why, and make them pass somehow? |
|
@eirslett I'll try to find some time soon to figure out what's going on. |
…itive file systems.
MikeThomsen
force-pushed
the
macos-bug
branch
from
84a282c
to
5a5eb07
Compare
|
It was an |
| return false; | ||
| } | ||
|
|
||
| boolean retVal = true; |
There was a problem hiding this comment.
Why is this stuff going on? Isn't it easier with destPath.toLowerCase().startsWith(destDir.toLowerCase())?
| * @return | ||
| */ | ||
| private boolean startsWithPath(String destPath, String destDir) { | ||
| if (destDir.startsWith(destDir)) { |
There was a problem hiding this comment.
Won't this check always be true? Is it supposed to be destPath?
There was a problem hiding this comment.
That was a typo on my part.
...ugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/ArchiveExtractor.java
Show resolved
Hide resolved
|
ok, thank you! |
|
There we go, 1.9.0 is released, merry christmas! 🎅 ❄️ 🎄 |
…itive file systems.
Summary
Tests and Documentation