Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support using installing node and yarn version matching the package.json engines property #798

Open
sarod opened this issue Feb 21, 2019 · 2 comments · May be fixed by #999
Open

Support using installing node and yarn version matching the package.json engines property #798

sarod opened this issue Feb 21, 2019 · 2 comments · May be fixed by #999

Comments

@sarod
Copy link

sarod commented Feb 21, 2019

Do you want to request a feature or report a bug?
feature

What is the current behavior?
You have to specify the nodeVersion and yarnVersion

What is the expected behavior?
The install-node-and-yarn should support using the version specified in package.json engines for node and yarn.
https://yarnpkg.com/lang/en/docs/package-json/#toc-engines

That could be configured by using "engines" as value for nodeVersion and or yarnVersion.
In such case frontend-maven plugin should install the most recent version matching the version expression in engines for yarn/node
@anton-johansson
Copy link

This is something that we'd love. We have a hard time keeping up with our frontend users when they bump versions, and this would really fix that problem. :)

Any plans for implementing this?

tisoft added a commit to advanova/frontend-maven-plugin that referenced this issue Sep 17, 2021
@tisoft
support installing node version from package.json engines
987d474 
fixes eirslett#798
@tisoft tisoft linked a pull request Sep 17, 2021 that will close this issue
Open
@tisoft
Copy link

tisoft commented Sep 17, 2021

I have added support for the node part in #999. Support for npm/yarn is still on my TODO.

tisoft added a commit to advanova/frontend-maven-plugin that referenced this issue Sep 19, 2021
@tisoft
support installing node version from package.json engines
6e30d51 
fixes eirslett#798
tisoft added a commit to advanova/frontend-maven-plugin that referenced this issue Sep 19, 2021
@tisoft
support installing npm version from package.json engines
d800399 
fixes eirslett#798
tisoft added a commit to advanova/frontend-maven-plugin that referenced this issue Sep 19, 2021
@tisoft
support installing yarn version from package.json engines
d78f3e7 
fixes eirslett#798
tisoft added a commit to advanova/frontend-maven-plugin that referenced this issue Jun 26, 2023
@tisoft
support installing node version from package.json engines
66e04f0 
fixes eirslett#798
tisoft added a commit to advanova/frontend-maven-plugin that referenced this issue Jun 26, 2023
@tisoft
support installing npm version from package.json engines
8b1d20e 
fixes eirslett#798
tisoft added a commit to advanova/frontend-maven-plugin that referenced this issue Jun 26, 2023
@tisoft
support installing yarn version from package.json engines
f5c88ad 
fixes eirslett#798
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support installing node,npm,yarn version from package.json engines advanova/frontend-maven-plugin
3 participants
@tisoft @anton-johansson @sarod