Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven build won't fail when integration-test fails #631

Closed
hnuttin opened this issue Jul 20, 2017 · 4 comments
Closed

Maven build won't fail when integration-test fails #631

hnuttin opened this issue Jul 20, 2017 · 4 comments

Comments

@hnuttin
Copy link

hnuttin commented Jul 20, 2017

When running grunt test during the 'integration-test' phase and some tests are failing, the maven builds is still succesfull. I would expect this not to be de default behaviour. I've tried experimenting with both the 'maven.test.failure.ignore' and 'maven.frontend.failOnError' property but this does not have any impact.

We see this behaviour since upgrading from version 0.0.20 to 1.4.

Strangely enough this is exactly the oposite as reported in #534

Any ideas? Thanks you.

@eirslett
Copy link
Owner

Try the newly released 1.5?

@hnuttin
Copy link
Author

hnuttin commented Jul 20, 2017

Same issue. Doing something wrong here? Plugin configuration:

<plugin>
    <groupId>com.github.eirslett</groupId>
    <artifactId>frontend-maven-plugin</artifactId>
    <version>1.5</version>
    <configuration>
        <workingDirectory>src/test/lib</workingDirectory>
        <nodeDownloadRoot>https://nodejs.org/dist/</nodeDownloadRoot>
    </configuration>
    <executions>
        <execution>
            <id>install node and npm</id>
            <goals>
                <goal>install-node-and-npm</goal>
            </goals>
            <configuration>
                <nodeVersion>v6.11.1</nodeVersion>
                <npmVersion>5.3.0</npmVersion>
            </configuration>
        </execution>
        <execution>
            <id>npm install</id>
            <goals>
                <goal>npm</goal>
            </goals>
        </execution>
        <execution>
            <id>run e2e</id>
            <goals>
                <goal>grunt</goal>
            </goals>
            <phase>integration-test</phase>
            <configuration>
                <arguments>e2e</arguments>
            </configuration>
        </execution>
    </executions>
</plugin>

@eirslett
Copy link
Owner

Try running grunt e2e on the command line and then echo $? to show the exit code. If grunt exits with exit code 0, the plugin will regard it as a successful run.

@hnuttin
Copy link
Author

hnuttin commented Jul 21, 2017

you are right, grunt exists with code 0, I'll look into it further, no frontend-maven-plugin issue, thanks alot for helping out!

@hnuttin hnuttin closed this as completed Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants