Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for yarn berry (.yarnrc.yml) in configured working directory #1097

Open
blutorange opened this issue Jul 4, 2023 · 0 comments
Open

Comments

@blutorange
Copy link

See #928 and #1012, which added the feature that yarn 1.x is not reinstalled when yarn 2.x+ is used. The changes in #1012 only checks for the .yarnrc.yml in the root directory of the Maven project (https://github.com/eirslett/frontend-maven-plugin/blob/master/frontend-maven-plugin/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/InstallNodeAndYarnMojo.java#L79-L81). We have the yarn project with multiple workspace in src/main/web, which is not checked by this plugin, so it reinstalls yarn every time.

The plugin does have a workingDirectory property, which points to the root folder of the yarn project (at least in our case). Could we also check for a .yarnrc.yml in that folder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant