Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade golangci-lint #75

Closed
magnusbaeck opened this issue Aug 7, 2023 · 0 comments · Fixed by #76
Closed

Upgrade golangci-lint #75

magnusbaeck opened this issue Aug 7, 2023 · 0 comments · Fixed by #76
Assignees
@magnusbaeck
Labels
dependencies Pull requests that update a dependency file

Comments

@magnusbaeck
Copy link
Member

Description

Judging by golangci/golangci-lint#2374, the old golangci-lint that we use isn't compatiable with Go 1.18, which is the compiler we're using when building the Docker images. Let's upgrade golangci-lint to the latest release and enable relevant linters that have been added since 1.43 that we currently use.

Motivation

We should be able to run the linter with the compiler we're using for the production builds.

Exemplification

N/A

Benefits

  • Be able to use the same compiler everywhere.
  • Access to new and updated linters.

Possible Drawbacks

None.
@magnusbaeck magnusbaeck added the dependencies Pull requests that update a dependency file label Aug 7, 2023
@magnusbaeck magnusbaeck self-assigned this Aug 9, 2023
@magnusbaeck magnusbaeck mentioned this issue Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magnusbaeck magnusbaeck

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade golangci-lint to 1.53.3 and adjust the linters used magnusbaeck/eiffel-goer
1 participant
@magnusbaeck