fix: Configure Rollup's external to support subpaths too #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fantua
approved these changes
Sep 19, 2022
egoist
changed the title
|
🎉 This PR is included in version 6.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
amitdahan
added a commit
to amitdahan/tsup
that referenced
this pull request
Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue with
--dts-resolve.When relying on types coming
from 'some-package/some-subpath', anything that is not importedfrom 'some-package'would end up getting unnecessarily bundled into the emitted.d.tsbundle.It seems we were configuring Rollup's
externalwith exact package names.Here we're adjusting to use the same regex approach taken with esbuild:
tsup/src/esbuild/index.ts
Lines 80 to 81 in d074dd9