"tsup-node" doesn't respect "noExternal" configuration

[eric-burel]

Hi,

I've been using "tsup-node to exclude all packages" with great pleasure to build some scripts while excluding all node_modules.

I am refactoring a monorepo, and I am in the special case where I have internal NPM packages that expose pure .ts code.
Therefore, I need those specific packages to be included in the build, despite being listed in the package.json.

The use case is pretty close to what's described for next-transpile-modules: https://www.npmjs.com/package/next-transpile-modules "code transpilation from local packages (think: a monorepo with a styleguide package)".

What's the equivalent in Tsup? How can we forcibly reinclude some packages while using tsup-node?

Here is an example: Devographics/Monorepo#117, the scripts are built in the "surveyform" directory, alongside the Next app. Package "core-models" lives in the shared folder, you can see how the package.json let's us expose pure TS files. I need this specific package to be bundled despite it being listed in package.json as a dependency.

[koshic]

@eric-burel is #538 can help?

[eric-burel]

@VladimirGrenaderov great tip thank you, however I don't really see the effect of this command, the built file is completely similar. The option is read (if I put a wrong string instead of an array it fails) but has no effect.

Example config:

const commonConfig = {
  clean: true,
  splitting: false,
  // Skip until .d.ts.map is also supported https://github.com/egoist/tsup/issues/564
  // dts: true,
  sourcemap: true,
  tsconfig: path.resolve(__dirname, "./tsconfig.tsup.json"),
  outDir: "scripts/dist",
  name: "",
  platform: "node" as const,
  target: "node14",
  noExternal: [/^@devographics($|\/)/],
  esbuildPlugins: [yamlPlugin({})],
};

Note that this is with tsup-node not tsup as I build a Node script. With tsup it works as intended. So this affects only tsup-node.

I am digging the code and it seems that the only thing tsup-node does is using the skipNodeModulesBundle: true option, which is a tad too aggressive as it also skips packages that are explicitely listed as not being externals.

The code in src/esbuild/external.ts seems to confirm that the "external" computation logic doesn't use the "noExternal" option when "skipNodeModulesBundle" is true. I think it should, I'll give a shot at a pull request.

[eric-burel]

#720 fixes but if someone needs it right now, they can use this config with tsup in replacement to tsup-node:

// whatever you need to bundle (here my shared "@devographics" internal packages and my path alias "~")
  noExternal: [/^@devographics($|\/)/, /^~/],
// everything else (this regexp is taken from the code used when tsup-node or skipNodeModulesBundle option are used)
  external: [/^[^.\/]|^\.[^.\/]|^\.\.[^\/]/],

[github-actions]

🎉 This issue has been resolved in version 6.3.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀