Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update postcss version to 8 #325

Merged
merged 5 commits into from Dec 6, 2020

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Sep 25, 2020

This updates the postcss version to 8 and moves the dependency to peerDependencies. Tests are all passing, but there are a couple of deprecation warnings.

Fixes #324

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #325 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files          10       10           
  Lines         328      328           
  Branches      115      115           
=======================================
  Hits          304      304           
  Misses         23       23           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 661c9ca...22bc2b8. Read the comment docs.

@ai
Copy link

ai commented Sep 28, 2020

LGTM

@wardpeet
Copy link
Collaborator

If we move it to peerdependencies, it's a breaking change. You'll have to give us some time to see if we can bundle more breaking changes.

@ghost
Copy link

ghost commented Nov 3, 2020

Hi, I'm curious what the status is? I'm waiting for an update to be released so I can use postcss 8 plugins with this rollup plugin...

@isaacl
Copy link

isaacl commented Nov 7, 2020

I didn't realize there was a PR and uploaded #335. Mine updates other deps that support postcss 8 and updates test snaps, I think it's probably better in the end.

@patagoniapy
Copy link

Any updates on when this can be merged? Not being able to use postcss-8 over two months down the road is killer.

@SASUKE40 SASUKE40 self-requested a review December 6, 2020 15:29
Copy link
Collaborator

@SASUKE40 SASUKE40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SASUKE40 SASUKE40 merged commit 700eb14 into egoist:master Dec 6, 2020
@egoist
Copy link
Owner

egoist commented Dec 7, 2020

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostCSS 8
10 participants