Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): options is actually optional #311

Merged
merged 2 commits into from Aug 30, 2020
Merged

fix(types): options is actually optional #311

merged 2 commits into from Aug 30, 2020

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Aug 19, 2020

No description provided.

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #311 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
- Coverage   92.68%   92.50%   -0.19%     
==========================================
  Files          10       10              
  Lines         328      320       -8     
  Branches      115      113       -2     
==========================================
- Hits          304      296       -8     
  Misses         23       23              
  Partials        1        1              
Impacted Files Coverage Δ
src/index.js 98.97% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2946eae...ae3247a. Read the comment docs.

Copy link
Collaborator

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thank you for taking the time and opening a Pull Request 🙏

@wardpeet wardpeet merged commit a7299a4 into egoist:master Aug 30, 2020
@github-actions
Copy link

🎉 This PR is included in version 3.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JounQin JounQin deleted the patch-1 branch August 30, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants