fix: make sourceMaps relative to the CSS output file #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now shows relative sourceMappingURL, rather than duplicating the full filePath
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
- Coverage 92.68% 92.47% -0.21%
==========================================
Files 10 10
Lines 328 319 -9
Branches 115 112 -3
==========================================
- Hits 304 295 -9
Misses 23 23
Partials 1 1
Continue to review full report at Codecov.
|
|
Any development on this? I tested this as a fix for visjs/vis-network#968 and visjs/vis-timeline#621, it resulted in the correct path being emitted. |
|
Tests appear to have failed because of a timeout, rather than any tests failing. |
wardpeet
changed the title
wardpeet
approved these changes
Aug 30, 2020
wardpeet
changed the title
|
🎉 This PR is included in version 3.1.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the example in:
test/fixtures/dist/extract--custom-path/this/is/extracted.cssthe sourceMappingURL was:
/*# sourceMappingURL=this/is/extracted.css.map */Meaning the browser would try and load the sourcemap from:
this/is/this/is/extracted.css.mapThis only happens when someone has set
extractto something likethis/is/extracted.css.I've changed this to run the map name through path.basename first, as the map is always dropped in the same folder as the css file.