Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicated banner after minified (fix #346) #359

Merged
merged 1 commit into from Jun 19, 2020

Conversation

fi3ework
Copy link
Collaborator

@fi3ework fi3ework commented Jun 18, 2020

By default, terser will preserve license(https://github.com/terser/terser#output-options). Set terser.output.comments to false to tell terser drop license, and we use bili's banner option.

@vercel
Copy link

vercel bot commented Jun 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/egoist/bili/pozh54dpq
✅ Preview: https://bili-git-fork-fi3ework-fix-346.egoist.vercel.app

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #359 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   75.33%   75.33%           
=======================================
  Files          11       11           
  Lines         454      454           
  Branches      169      165    -4     
=======================================
  Hits          342      342           
  Misses        107      107           
  Partials        5        5           
Impacted Files Coverage Δ
src/index.ts 73.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e93f812...b717609. Read the comment docs.

@fi3ework fi3ework requested a review from egoist June 18, 2020 17:43
@egoist egoist merged commit 9a5e211 into egoist:master Jun 19, 2020
@egoist
Copy link
Owner

egoist commented Jun 19, 2020

🎉 This PR is included in version 5.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants