Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document runtime dependencies for building vue #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bodograumann
Copy link

In the latest versions of rollup-plugin-vue the normalizers from vue-runtime-helpers are not inlined any more.
So they need to be added as dependencies.

This resolves #221.

See also vuejs/rollup-plugin-vue#308 (comment)

In the latest versions of `rollup-plugin-vue` the normalizers from `vue-runtime-helpers` are not inlined any more.
So they need to be added as dependencies.
@vercel
Copy link

vercel bot commented Oct 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/egoist/bili/3svxv0bmp
✅ Preview: https://bili-git-patch-2.egoist.vercel.app

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #507 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #507   +/-   ##
=======================================
  Coverage   75.21%   75.21%           
=======================================
  Files          11       11           
  Lines         456      456           
  Branches      170      170           
=======================================
  Hits          343      343           
  Misses        108      108           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655d499...59c184c. Read the comment docs.

@Scttpr
Copy link

Scttpr commented Aug 26, 2021

Do you have any updates on this issue ?

@bodograumann
Copy link
Author

No reaction from the maintainer :-(
So no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Adding rollup-plugin-vue now requires inline-bundle of rollup-plugin-commonjs when generating esm?
2 participants