-
Notifications
You must be signed in to change notification settings - Fork 111
[BUGFIX] webpack detection should also consider supported versions #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d76c65e
to
b36244a
Compare
b36244a
to
427a28e
Compare
one of the runs failed due to what appears to be an npm issue (unrelated to this PR).... re-running |
the new failures also look spurious. One looks suspicious but doesn't appear to be reproducible locally https://github.com/ef4/ember-auto-import/pull/414/checks?check_run_id=2833013788 Should I just re-roll the CI dice? Is this instability common? |
I think those fastboot failures are real and probably caused by upstream changes in a fastboot-related package. You may not see them locally if you're installing via lockfile. |
I'll try that |
@ef4 yup, lockfile prevented local reproduction. Thanks for pointing in that direction.
|
427a28e
to
27485d4
Compare
@@ -22,7 +22,7 @@ function upgradeFastbootFormat() { | |||
let upgrader = new Project('fastboot_upgrader', { | |||
files: { | |||
'index.js': ` | |||
const Funnel = require('broccoli-funnel'); | |||
const { Funnel } = require('broccoli-funnel'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broccoli-funnel was not pinned, rather it was a random transitive dependency that was being pulled in. The latest version changed it's API, and decoupled its "functional" api from its "classical" api. (thanks @rwjblue)
To correct this, I explicitly added broccoli-funnel as a devDep + imported it correctly
bah, failure due to NPM install... rerunning |
green! @ef4 I don't have release bit on NPM, so I'll leave that to you :) |
No description provided.