Skip to content

[BUGFIX] webpack detection should also consider supported versions #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

stefanpenner
Copy link
Collaborator

No description provided.

@stefanpenner stefanpenner force-pushed the fix-webpack-warning branch from d76c65e to b36244a Compare June 15, 2021 19:29
@stefanpenner stefanpenner force-pushed the fix-webpack-warning branch from b36244a to 427a28e Compare June 15, 2021 19:34
@stefanpenner
Copy link
Collaborator Author

stefanpenner commented Jun 15, 2021

one of the runs failed due to what appears to be an npm issue (unrelated to this PR).... re-running

@stefanpenner
Copy link
Collaborator Author

stefanpenner commented Jun 15, 2021

the new failures also look spurious. One looks suspicious but doesn't appear to be reproducible locally https://github.com/ef4/ember-auto-import/pull/414/checks?check_run_id=2833013788

Should I just re-roll the CI dice? Is this instability common?

@ef4
Copy link
Collaborator

ef4 commented Jun 15, 2021

I think those fastboot failures are real and probably caused by upstream changes in a fastboot-related package. You may not see them locally if you're installing via lockfile.

@stefanpenner
Copy link
Collaborator Author

I think those fastboot failures are real and probably caused by upstream changes in a fastboot-related package. You may not see them locally if you're installing via lockfile.

I'll try that

@stefanpenner
Copy link
Collaborator Author

@ef4 yup, lockfile prevented local reproduction. Thanks for pointing in that direction.

not ok 2 fastboot3-dev > it is using schema version 5
  ---
  message: "failed"
  severity: failed
  actual: 3
  expected: 5
  stack:     at Assert.equal (/Users/stefanpenner/src/ef4/ember-auto-import/node_modules/qunit/qunit/qunit.js:3072:14)

@@ -22,7 +22,7 @@ function upgradeFastbootFormat() {
let upgrader = new Project('fastboot_upgrader', {
files: {
'index.js': `
const Funnel = require('broccoli-funnel');
const { Funnel } = require('broccoli-funnel');
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broccoli-funnel was not pinned, rather it was a random transitive dependency that was being pulled in. The latest version changed it's API, and decoupled its "functional" api from its "classical" api. (thanks @rwjblue)

To correct this, I explicitly added broccoli-funnel as a devDep + imported it correctly

@stefanpenner
Copy link
Collaborator Author

bah, failure due to NPM install... rerunning

@stefanpenner
Copy link
Collaborator Author

green! @ef4 I don't have release bit on NPM, so I'll leave that to you :)

@ef4 ef4 merged commit 18ce3df into master Jun 16, 2021
@ef4 ef4 deleted the fix-webpack-warning branch June 16, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants