Turn the Lexer, Parser & Composer into generators #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The `push` argument of `new Lexer()` is dropped, and instead its `lex()` method is now a Generator<string> that allows for the lexemes to be iterated.
BREAKING CHANGE: The `push` argument of `new Parser()` is dropped, and instead its `parse()`, `next()` and `end()` methods are now generators that allow for the parsed tokens to be iterated.
Adds a convenience method `composer.compose(tokens)`. BREAKING CHANGE: The `push` argument of `new Composer()` is dropped, and instead its `next()` and `end()` methods are now generators that allow for the parsed documents to be iterated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In retrospect, this seems so obvious.
All of the parsing stages now provide generators, so that their output may be iterated, rather than needing to provide them with a callback function. As a convenience, a
compose()method is also added:This is a breaking change to the API provided for these classes in the preceding 2.0.0-4 release.