Make Pair not extend NodeBase; drop its prop forwarding #250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #249, so the current commit log includes its changes as well.
BREAKING CHANGE: While the inheritance of the class is just an implementation detail, dropping the prop forwarding means that a user that previously set the
commentBefore
,comment
orspaceBefore
property of a pair will now need to set it for the appropriate key or value.While adjusting the test suite for the changes, the somewhat surprising behaviour of multi-line comments on scalar values getting handled as
commentBefore
instead ofcomment
is also dropped. Also, the behaviour of line comments in flow collections is significantly improved.