Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify default options #417

Open
SachsKaylee opened this issue Jul 5, 2020 · 1 comment
Open

Specify default options #417

SachsKaylee opened this issue Jul 5, 2020 · 1 comment

Comments

@SachsKaylee
Copy link

Hello there,

as of OTP 23 we are running into the issue that SSLv3 is no longer supported, which in itself is great. Howerver it seems that
HTTPPoison still attempts to use it, which raises an error.

(HTTPoison.Error) {:options, {:sslv3, {:versions, [:"tlsv1.2", :"tlsv1.1", :tlsv1, :sslv3]}}}
        (httpoison 1.7.0) lib/httpoison.ex:128: HTTPoison.request!/5

This is easy to fix by simply adding [ssl: [versions: :"tlsv1.2"]] as an option when making HTTP requests. However, this become quite the maintenance burden when having to retroactively add this to every since request.

Skimming through the source code of hackney and HTTPPoison I did not see a config value to specify this as a default, but I'm quite sure I missed something as this seems like a common use case.

Thank you for your time

@Fudoshiki
Copy link

Fudoshiki commented Nov 29, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants