Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinction between the two timeouts #299

Closed
Dzol opened this issue Nov 8, 2017 · 5 comments · Fixed by #350
Closed

Distinction between the two timeouts #299

Dzol opened this issue Nov 8, 2017 · 5 comments · Fixed by #350

Comments

@Dzol
Copy link

Dzol commented Nov 8, 2017

I read the various issues here around timeouts but none explain the difference between the two that are documented. What exactly do the timeout and recv_timeout options mean? I'm guessing the following:

  • timeout to establish (open) a TCP connection
  • recv_timeout to receive an HTTP response having sent a request

The documentation says "timeout used when receiving a connection" for the recv_timeout but I wouldn't say we receive a connection as a client 😕 Is the guess above right?

@edgurgel
Copy link
Owner

edgurgel commented Nov 8, 2017

Oh hey! Yes, it's confusing. Take a look at this issue and it may help clarify things: #215

@Dzol
Copy link
Author

Dzol commented Nov 10, 2017

Hey 🙂

I dug into Hackney... its connect_timeout is about TCP session establishment and the recv_timeout is about HTTP response time. I'll get the source references together and post a PR with a description in documentation in the coming week.

How does that sound?

@edgurgel
Copy link
Owner

That would be great 👍

@Dzol
Copy link
Author

Dzol commented Aug 22, 2018

Hey @edgurgel,

Thanks for your patience. I opened a small PR.

Do you have some suggestions on the phrasing that would make the details even more clear.

@edgurgel
Copy link
Owner

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants