Skip to content

fix: Remove JSON omitempty from SimpleReading value #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

weichou1229
Copy link
Member

The SimpleReading can contain the empty string.

Close #725

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) not impact the test
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) not impact doc

Testing Instructions

  • Run edgex and device service
  • Query empty string value from device service
  • Inspect the reading should contain empty string value

New Dependency Instructions (If applicable)

Sorry, something went wrong.

cloudxxx8
cloudxxx8 previously approved these changes Apr 19, 2022
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 requested a review from lenny-goodell April 19, 2022 07:04
The SimpleReading can contain the empty string.

Close edgexfoundry#725

Signed-off-by: bruce <weichou1229@gmail.com>
@weichou1229 weichou1229 changed the title feat: Remove JSON omitempty from SimpleReading value fix: Remove JSON omitempty from SimpleReading value Apr 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #726 (d83bf3a) into main (ca0d31f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #726   +/-   ##
=======================================
  Coverage   63.79%   63.79%           
=======================================
  Files          79       79           
  Lines        3002     3002           
=======================================
  Hits         1915     1915           
  Misses        901      901           
  Partials      186      186           
Impacted Files Coverage Δ
dtos/reading.go 74.64% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0d31f...d83bf3a. Read the comment docs.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit f15f824 into edgexfoundry:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading value field should allow empty string
4 participants