Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Core Keeper implementation #4790

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: Core Keeper implementation #4790

wants to merge 1 commit into from

Conversation

jackchenjc
Copy link
Contributor

closes #4783

Not yet integrated with OpenZiti changes.

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@jackchenjc
feat: Core Keeper implementation
fd88077 
closes edgexfoundry#4783

Signed-off-by: Jack Chen <jack@iotechsys.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 13, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
3 Security Hotspots
No data about Coverage
1.2% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 24.04580% with 398 lines in your changes are missing coverage. Please review.

Project coverage is 40.73%. Comparing base (971ded0) to head (fd88077).

Files Patch % Lines
internal/pkg/infrastructure/redis/kv.go 0.00% 157 Missing ⚠️
internal/pkg/infrastructure/redis/registry.go 0.00% 88 Missing ⚠️
internal/pkg/infrastructure/redis/client.go 0.00% 72 Missing ⚠️
internal/pkg/infrastructure/redis/queries.go 0.00% 61 Missing ⚠️
internal/core/keeper/controller/http/kv.go 84.12% 5 Missing and 5 partials ⚠️
internal/core/keeper/controller/http/registry.go 87.95% 6 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4790      +/-   ##
==========================================
- Coverage   41.62%   40.73%   -0.89%     
==========================================
  Files         105      109       +4     
  Lines        9858    10382     +524     
==========================================
+ Hits         4103     4229     +126     
- Misses       5402     5791     +389     
- Partials      353      362       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Core Keeper Service
2 participants
@jackchenjc @codecov-commenter