Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Future development #35

Closed
peterennis opened this issue May 17, 2019 · 5 comments
Closed

Future development #35

peterennis opened this issue May 17, 2019 · 5 comments

Comments

@peterennis
Copy link
Contributor

@edgarordonez

This issue: ionic-team/stencil#1535

If it is fixed then 0.18.1 seems to be a good place to
end the D3-Stencil version 1 line.

There are many breaking changes here:

https://github.com/ionic-team/stencil/blob/master/BREAKING_CHANGES.md

Call this the D3-Stencil version 2? WDYT?

Capture550

@peterennis
Copy link
Contributor Author

peterennis commented May 17, 2019

When the issue is fixed I can add Husky back in
per this commit:

30a5a31

Done here: peterennis#4

@peterennis
Copy link
Contributor Author

@peterennis
Copy link
Contributor Author

@edgarordonez FYI rollup/rollup#2865

@ghost
Copy link

ghost commented May 20, 2019

Hello @peterennis,

Thanks for your time. I'm a little bit busy, but I'll be more relaxed the next week. However, I'm gonna try to update d3-stencil tonight since both issues were closed. So, maybe we can try to update, right?

Keep in touch!

Thanks! 🙏💪🏼

@peterennis
Copy link
Contributor Author

@edgarordonez
PR updated. This comment: #31 (comment)
You can try to update. I recommend ignoring the CI coveralls if you get it to build and run.
However, I am curious to know what is blocking it.

@ghost ghost closed this as completed Jun 21, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant