add flexibility to footer

[chrisguindon]

Signed-off-by: Christopher Guindon chris.guindon@eclipse-foundation.org

[netlify]

✔️ Deploy Preview for eclipsefdn-hugo-solstice-theme ready!

🔨 Explore the source changes: 53742aa

🔍 Inspect the deploy log: https://app.netlify.com/sites/eclipsefdn-hugo-solstice-theme/deploys/60be6a2176986a0007b3139d

😎 Browse the preview: https://deploy-preview-230--eclipsefdn-hugo-solstice-theme.netlify.app

[autumnfound]

The code looks great! Was the change in naming convention for the link partials an intentional choice?

[chrisguindon]

@autumnfound Yes, we are not consistent so I had to pick:
https://github.com/EclipseFdn/hugo-solstice-theme/blob/master/layouts/partials/sidebar-block.html
https://github.com/EclipseFdn/hugo-solstice-theme/blob/master/layouts/partials/collapsible-menu.html

I decided to use the id name for each section. However, since most of them are using _ in the root of the partial folder, I went with footer_links and footer_js.

There is always logic to my madness but I don't have a strong opinion. I can change it to use _ if you feel strongly about it.