This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
Yiliu/master/update mobile sidebar #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for eclipsefdn-hugo-solstice-theme ready! Built with commit 3433044 https://deploy-preview-204--eclipsefdn-hugo-solstice-theme.netlify.app |
flora8984461
requested review from
chrisguindon,
autumnfound and
ericpoirier
|
I think there is a miss in the style, which makes the active link bold style gone. Please check this fix: https://github.com/EclipseFdn/solstice-assets/pull/236/files |
autumnfound
suggested changes
Mar 2, 2021
autumnfound
reviewed
Mar 2, 2021
Signed-off-by: Eric Poirier <eric.poirier@eclipse-foundation.org>
Signed-off-by: Eric Poirier <eric.poirier@eclipse-foundation.org>
Signed-off-by: Eric Poirier <eric.poirier@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
flora8984461
force-pushed
the
yiliu/master/updateMobileSidebar
branch
from
def42ff
to
57220ab
Compare
This was referenced Mar 12, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates on mobile sidebar, based on IoT and Eric's PR #201