This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
initial trial to custom header for sub-sites #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for eclipsefdn-hugo-solstice-theme failed. Built with commit 68cf624 https://app.netlify.com/sites/eclipsefdn-hugo-solstice-theme/deploys/60524691bfe51000074a03da |
chrisguindon
suggested changes
Jan 19, 2021
| @@ -0,0 +1,11 @@ | |||
| items: | |||
| - | |||
| page_url: '/subsite-1' | |||
There was a problem hiding this comment.
@flora8984461 to confirm, this new logo will be used on sub pages of that section right?
There was a problem hiding this comment.
Yes, subsite-1, and its children, subsite-1/*/* ...
flora8984461
force-pushed
the
yiliu/master/customHeader
branch
from
5e7262d
to
514ade5
Compare
autumnfound
reviewed
Jan 20, 2021
autumnfound
reviewed
Jan 21, 2021
layouts/partials/nav_toggle.html
Outdated
| <img width="{{ $.Page.Params.logo_width | default $.Site.Params.logo_width | default "140"}}" class="logo-eclipse-default-mobile img-responsive" src="{{ . | absURL }}" alt="{{ $.Site.Title }}" /> | ||
| {{ $currentPageLogo := . }} | ||
| {{ $currentPageLogoTitle := $.Site.Title }} | ||
| {{ $currentPageLogoLink := "" | absLangURL }} |
There was a problem hiding this comment.
I wouldn't double URL convert this (you call absLangURL later on as well). Might do something unexpected, remove it here and just leave it in the later line
autumnfound
approved these changes
Feb 22, 2021
chrisguindon
suggested changes
Feb 25, 2021
added 7 commits
March 8, 2021 15:58
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
flora8984461
force-pushed
the
yiliu/master/customHeader
branch
from
5c85960
to
c700900
Compare
Updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #88
One example can be https://deploy-preview-196--eclipsefdn-hugo-solstice-theme.netlify.app/subsite-1/
You can assume it is a subsite with its independent logo and logo url.
Another example can be https://deploy-preview-196--eclipsefdn-hugo-solstice-theme.netlify.app/third-parent/
You can assume it's another subsite with another independent logo and logo url.
Signed-off-by: Yi Liu yi.liu@eclipse-foundation.org