Remove of deprecated .xtext.junit4 and .xbase.junit4

[LorenzoBettini]

I propose to ditch for good those deprecated projects, whose mechanisms are provided by the corresponding split projects .testing and .ui.testing.

The only thing to address is the AbstractXtextTests and ResourceLoadHelper, which don't have a counterpart in the new projects. We still use them a lot, by duplicating them, in several test projects in Xtext. We could re-introduce them in the new testing projects before the proposed removal of the deprecated ones. This can be achieved in a separate PR.

The removal will allow us to also get rid of the corresponding .tests projects.

[cdietrich]

should we add another reminder to release notes?
is all marked forRemoval?

[cdietrich]

isnt ResourceLoadHelper unused ? (the deprecated one)

[LorenzoBettini]

@cdietrich I'll check for the forRemoval later.
ResourceLoadHelper seems to be just an interface...

What I still have to understand is whether the AbstractXtextTests copied in most of our test projects is always the same.

[cdietrich]

i assume yes

[LorenzoBettini]

@cdietrich indeed forRemoval seems everywhere on those older projects

[LorenzoBettini]

By the way, we already have org.eclipse.xtext.ui.testing.util.ResourceLoadHelper in ui.testing, so probably that's the right place to be. In any case, we can't remove that one: it's in the new project and it's used in some of content assist base test classes.

In the new AbstractXtextTests base class, I won't make it implement that interface, though, since it's not used in that context

[LorenzoBettini]

@cdietrich With #3038 merged, should we go on removing the old projects for 2.35?

[cdietrich]

I would Annonce in rel notes and remove in 2.36

[szarnekow]

I would Annonce in rel notes and remove in 2.36

I'd do the same.