New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch upgrading Xtext dependency on Log4j 1 to Log4j 2. #2940
Comments
To make this discussion self-contained, can you please summarize the arguments here? It's not obvious that the Eclipse forum will be around in some future. Other than that:
So getting back to the initial question: Please add more information here. |
Hi. Sure, here's a summary:
To clarify something, I am not requesting such patch to be made. I have already patched 32 Xtext bundles (and most of Xtend 1 and 2 and Xpand). And I believe that patching the rest is quite doable. Also, keep in mind that I'm not asking the Xtext team to do this one change for us, for one customer. We already have our own Xtext fork and build from that, so we are good, and we don't need Xtext to include these patches, but we would like to be able to benefit from future Xtext improvements, and to contribute to the community, as we know we are definitely not the only ones that have encountered this sort of problem. I do like the slf4j option, and I am not familiar with reload4j, I've just taken a very quick look. If it would allow us to make sure that there are not references to log4j1 in manifest files or feature dependencies or pom files, and that log4j1 is completely absent from a build when we declare a dependency on Xtext (or Xtend), than I'm all for it. I would appreciate help or pointers on where to get help on how to do that. But in any case, the point is that I'm offering a set of patches that are already done (and I could try to finish the rest), and that could be used maybe as a stepping stone towards replacing the dependency on the ancient log4j1 for a better one. So, if you would like so, I could open a Pull Request and you can decide whether to continue. |
I have created patches for Xtext 2.31 upgrading Log4j 1 to Log4j 2, as discussed in the Xtext Eclipse forum, and I would like to contribute these if the Xtext team is interested. If so, I can open a pull request.
The reasons are discussed in the forum linked above.
The text was updated successfully, but these errors were encountered: