Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response#end should throw ISE if used inside headers end handler #4556

Merged
merged 1 commit into from Dec 5, 2022
Merged

Response#end should throw ISE if used inside headers end handler #4556

merged 1 commit into from Dec 5, 2022

Conversation

tsegismont
Copy link
Contributor

Fixes #4546

This aligns behaviors of Http 1 and Http2 servers.

@tsegismont
Response#end should throw ISE if used inside headers end handler (ecl…
02a00f5 
…ipse-vertx#4549)

Fixes eclipse-vertx#4546

This aligns behaviors of Http 1 and Http2 servers.

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont changed the title Response#end should throw ISE if used inside headers end handler (#4549) Response#end should throw ISE if used inside headers end handler Dec 5, 2022
@tsegismont tsegismont linked an issue Dec 5, 2022 that may be closed by this pull request
Metric - Http1xServerConnection request is null #4546
Closed
@tsegismont tsegismont requested a review from vietj December 5, 2022 15:21
@tsegismont tsegismont merged commit e0d35d7 into eclipse-vertx:4.3 Dec 5, 2022
@tsegismont tsegismont deleted the backport_4549 branch December 5, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vietj vietj vietj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metric - Http1xServerConnection request is null
2 participants
@tsegismont @vietj