Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response#end should throw ISE if used inside headers end handler #4549

Merged
merged 1 commit into from Dec 5, 2022
Merged

Response#end should throw ISE if used inside headers end handler #4549

merged 1 commit into from Dec 5, 2022

Conversation

tsegismont
Copy link
Contributor

@tsegismont tsegismont commented Nov 23, 2022 •
edited

See #4546

This aligns behaviors of Http 1 and Http2 servers.

@tsegismont
Response#end should throw ISE if used inside headers end handler
65c8664 
See eclipse-vertx#4546

This aligns behaviors of Http 1 and Http2 servers.

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont
Copy link
Contributor Author

@vietj ok to merge?

@vietj
Copy link
Member

vietj commented Dec 5, 2022

we need another PR to backport to 4.3 branch

@tsegismont tsegismont merged commit edfccc6 into eclipse-vertx:master Dec 5, 2022
@tsegismont tsegismont deleted the issue/4546 branch December 5, 2022 15:18
tsegismont added a commit to tsegismont/vert.x that referenced this pull request Dec 5, 2022
@tsegismont
Response#end should throw ISE if used inside headers end handler (ecl…
02a00f5 
…ipse-vertx#4549)

Fixes eclipse-vertx#4546

This aligns behaviors of Http 1 and Http2 servers.

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit that referenced this pull request Dec 5, 2022
@tsegismont
Response#end should throw ISE if used inside headers end handler (#4549…
e0d35d7 
…) (#4556)

Fixes #4546

This aligns behaviors of Http 1 and Http2 servers.

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vietj vietj vietj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsegismont @vietj