Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2-maven-site includes bundles in the repository #932

Closed
laeubi opened this issue May 4, 2022 · 1 comment
Closed

p2-maven-site includes bundles in the repository #932

laeubi opened this issue May 4, 2022 · 1 comment
Labels
🚨 regression Regression compared to previous release - blocks upcoming release and other merges
Milestone

Comments

@laeubi
Copy link
Member

laeubi commented May 4, 2022

This seems to be a regression from Tycho 2.7.0 > 2.7.1 (even though I don't see a reason why), with 2.7.0 no bundles are included.

Originally posted by @laeubi in #931 (reply in thread)

@laeubi
Copy link
Member Author

laeubi commented May 4, 2022

Reproducer project is here: https://github.com/eclipse/tycho/files/8621795/tycho-p2-site-test.zip
With Tycho 2.7.0 no bundles are included, with Tycho 2.7.2 bundles are included...

laeubi referenced this issue in jetty/jetty.project May 4, 2022
Bumps tycho-p2-repository-plugin from 2.7.1 to 2.7.2.

---
updated-dependencies:
- dependency-name: org.eclipse.tycho:tycho-p2-repository-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@laeubi laeubi added the 🚨 regression Regression compared to previous release - blocks upcoming release and other merges label May 4, 2022
@laeubi laeubi pinned this issue May 4, 2022
@laeubi laeubi added this to the 2.7.3 milestone May 4, 2022
laeubi added a commit to laeubi/tycho that referenced this issue May 4, 2022
reckart added a commit to apache/uima-uimaj that referenced this issue May 5, 2022
- Pull the externalized strings from the feature.properties files back into the feature.xml files because the Tycho updatesite tooling apparently does not support the externalized strings (also we never translated them...)
- Downgrade to Tycho 2.7.0 due to eclipse-tycho/tycho#932
- Mark the automatically-generated import for `com.apple.eio` in the runtime bundle as optional to avoid bundles not being installable on JREs that do not offer this package
- Remove the `.feature.group` suffix from the feature module artifactIds to avoid the final update site containing features named `XXX.feature.group.feature.group`
- Remove tycho declarations that are duplicate now that the base configuration has been pulled into a profile
@laeubi laeubi closed this as completed in d2f68e2 May 5, 2022
laeubi added a commit that referenced this issue May 5, 2022
laeubi added a commit to laeubi/tycho that referenced this issue May 5, 2022
reckart added a commit to apache/uima-uimaj that referenced this issue May 6, 2022
- Upgrade to Tycho 2.7.3-SNAPSHOT to get a fix for eclipse-tycho/tycho#932
- Disable installing and deploying and even building the update site ZIP for the traditional update site. It is enough to have it as a folder atm.
@laeubi laeubi unpinned this issue May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 regression Regression compared to previous release - blocks upcoming release and other merges
Projects
None yet
Development

No branches or pull requests

1 participant