Xtext does no longer build with the Tycho 2.4 release candidate #179
Comments
|
Xtend shows the same problem |
|
unfortunately i still have to find out how to minimize this |
|
Can you run a (local) Debug build with -X to see if a stacktrace is provided? |
|
created a minimalized xtext-eclipse build on branch (am not sure if i did this correct) the stacktrace is |
|
|
will also try to reproduce locally. update: server shows problem also with 3.6 |
|
looks like it depends on the parameters maven is called with |
|
@HannesWell maybe this is related to #166 |
|
do you know if the settings xmls the eclipse cbi has floating around can be seen somewhere update: not really :( |
|
ok. looks like we call maven without any goals |
|
your pom sets a |
|
indeed. with explicit goals it works. with the default it fails. number is #166 |
cdietrich
changed the title
I think it is the change in A symptom of this bug should be that the Target-Platform resolution is skipped. |
|
Should I create a fix? |
Yes please. |
|
@mickaelistria as discussed on the mailinglist might the alternative (do not having a staging but just a second snapshot build) be less work? We might then just proceed with the new release-process instead? |
…ion from eclipse-tycho#166) If default goals are used Maven can be invoked without specifying goals explicitly in the command, so the List of goals is empty. This had the consequence, that the AbstractMavenLifecycleParticipant false detected a clean-only build and skipped dependency/target-platform resolution, which lead to follow up errors. The logic to detect 'clean-only' builds is improved to consider the described case. Change-Id: I68b7abf61835665a648a0bc006153c4631b56ff8 Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
…ion from eclipse-tycho#166) If default goals are used Maven can be invoked without specifying goals explicitly in the command, so the List of goals is empty. This had the consequence, that the AbstractMavenLifecycleParticipant false detected a clean-only build and skipped dependency/target-platform resolution, which lead to follow up errors. The logic to detect 'clean-only' builds is improved to consider the described case.
Yes, it would be, but for this release, we've already started a release process that involve staging. So I think it's better to stick with it for this release. |
If default goals are used Maven can be invoked without specifying goals explicitly in the command, so the List of goals is empty. This had the consequence, that the AbstractMavenLifecycleParticipant false detected a clean-only build and skipped dependency/target-platform resolution, which lead to follow up errors. The logic to detect 'clean-only' builds is improved to consider the described case.
|
@cdietrich your call: do you need it fixed badly for 2.4 or are you fine with explicitly setting the goal until 2.5 ? |
|
i guess it depends on the 2.5 timeline. unfortunately i dont know if a similar search is possible for git.eclipse.org/r |
If default goals are used Maven can be invoked without specifying goals explicitly in the command, so the List of goals is empty. This had the consequence, that the AbstractMavenLifecycleParticipant false detected a clean-only build and skipped dependency/target-platform resolution, which lead to follow up errors. The logic to detect 'clean-only' builds is improved to consider the described case.
|
@cdietrich I wonder if it would be an option for xtext to always build against (or with a separate nightly build) against the current tycho-snapshot? It seems your builds cover some cases that would be good to know about early. |
|
i know to less about jenkins files on how to set a nightly or weekly trigger and have the branch up to date |
|
You can find some hints here, the most declarative and easy would be to use |
|
ill give it a try. |
|
ok, looks like we now have a eveningly build with tycho 2.5.0-SNAPSHOT for xtext-eclipse and xtext-xtend in place now |
|
Please try https://oss.sonatype.org/content/repositories/orgeclipsetycho-1068 as new staging repo for 2.4 release, which should include the fix. I hope to release it tomorrow afternoon unless issue is not resolved or other blockers are found. |
|
build works fine with the new RC |
Xtext does no longer build with the Tycho 2.4 release canidate
https://ci.eclipse.org/xtext/job/xtext-eclipse/job/cd_testTycho24/3/console
when i last tested the snapshot 10 days ago it still was working
https://ci.eclipse.org/xtext/job/xtext-eclipse/job/cd_testTycho23/22/consoleFull
The text was updated successfully, but these errors were encountered: