Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AllKnownEEsResolutionHints is missing equals/hascode causing target resoloution for every project #170

Closed
laeubi opened this issue Jul 3, 2021 · 3 comments
Closed

AllKnownEEsResolutionHints is missing equals/hascode causing target resoloution for every project #170

laeubi opened this issue Jul 3, 2021 · 3 comments
Milestone
2.5

Comments

@laeubi
Copy link
Member

laeubi commented Jul 3, 2021

If AllKnownEEsResolutionHints is used (e.g. <resolveWithExecutionEnvironmentConstraints>false</resolveWithExecutionEnvironmentConstraints> configured in the build) the target is resolved over and over again because AllKnownEEsResolutionHints do not use any caching or meaningful equals/hashcode implementation
laeubi added a commit to laeubi/tycho that referenced this issue Jul 3, 2021
@laeubi
Fix eclipse-tycho#170 - AllKnownEEsResolutionHints is missing equals/…
6841107 
…hashcode causing

target resolution for every project

Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@mickaelistria
Copy link
Contributor

Good catch! Shouldn't we make AllKnownEEResolutionHints a singleton as well?

@laeubi
Copy link
Member Author

laeubi commented Jul 3, 2021

I have first though about that but it is created on a per project basis and fills the EEs from the project somewhat... So i have not investigated how this might be cached somewhere...

@mickaelistria
Copy link
Contributor

OK

@laeubi laeubi added this to the 2.5 milestone Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

No branches or pull requests
2 participants
@mickaelistria @laeubi