Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enclose each step of Repairnator in a timeout #351

Closed
surli opened this issue Sep 28, 2017 · 7 comments
Closed

Enclose each step of Repairnator in a timeout #351

surli opened this issue Sep 28, 2017 · 7 comments

Comments

@surli
Copy link
Contributor

surli commented Sep 28, 2017

No description provided.

@surli
Copy link
Contributor Author

surli commented Mar 20, 2018

We got a lot of stucked docker containers because of non responding mvn commands. I think we should actually put a timeout for each step of Repairnator process.

@surli surli changed the title Enclose mvn test in timeout and catch external errors Enclose each step of Repairnator in a timeout Mar 20, 2018
@fermadeiral
Copy link
Contributor

It seems a good idea. How would we choose the timeout for each step? I mean, each step differs (maybe a lot) regarding the time of execution, e.g. clone can be way faster than test, thus we should probably put a timeout for test greater than for clone. Maybe we could define, for each step, a timeout based on previous experiments, e.g. for step clone the average (or median) execution time is x, then we get this x to be the timeout for step clone? WDYT?

@surli
Copy link
Contributor Author

surli commented Mar 20, 2018

I was actually thinking about 3 different mechanism:

  1. for all steps using maven goal, to use the same mechanism as Travis: 10 minutes without log = timeout,
  2. for repair steps, to use continue using our current timeouts,
  3. for other steps, to define an absolute timeout (and yeah, we can use your idea there)

@fermadeiral
Copy link
Contributor

This sounds a good plan.

@surli
Copy link
Contributor Author

surli commented Mar 20, 2018

For the record, step one might be done for free using changes proposed in: apache/maven-invoker#1

surli added a commit that referenced this issue Mar 21, 2018
…473)

* First step to manage timeout in Maven goals based on the output #351

* Fix checkstyle
@surli
Copy link
Contributor Author

surli commented Mar 21, 2018

Actually I think I won't do step 3: each time the build got stuck it was because of Maven goal, so I proposed to already close this issue. WDYT @fermadeiral ?

@fermadeiral
Copy link
Contributor

each time the build got stuck it was because of Maven goal

In this case, it's not necessary by now to put timeout in the other steps. I agree about closing this issue. If we have problems in the future because of the other steps, then we put timeout for them.

@surli surli closed this as completed Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants