New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enclose each step of Repairnator in a timeout #351
Comments
We got a lot of stucked docker containers because of non responding mvn commands. I think we should actually put a timeout for each step of Repairnator process. |
It seems a good idea. How would we choose the timeout for each step? I mean, each step differs (maybe a lot) regarding the time of execution, e.g. clone can be way faster than test, thus we should probably put a timeout for test greater than for clone. Maybe we could define, for each step, a timeout based on previous experiments, e.g. for step clone the average (or median) execution time is x, then we get this x to be the timeout for step clone? WDYT? |
I was actually thinking about 3 different mechanism:
|
This sounds a good plan. |
For the record, step one might be done for free using changes proposed in: apache/maven-invoker#1 |
Actually I think I won't do step 3: each time the build got stuck it was because of Maven goal, so I proposed to already close this issue. WDYT @fermadeiral ? |
In this case, it's not necessary by now to put timeout in the other steps. I agree about closing this issue. If we have problems in the future because of the other steps, then we put timeout for them. |
No description provided.
The text was updated successfully, but these errors were encountered: