Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom open connection for different network types #574

Merged
merged 3 commits into from Dec 22, 2021

Conversation

GilGil1
Copy link
Contributor

@GilGil1 GilGil1 commented Dec 22, 2021

No description provided.

@MattBrittan MattBrittan merged commit 6f41a8c into eclipse:master Dec 22, 2021
@MattBrittan
Copy link
Contributor

Thanks for the PR - looks good and all tests passed so I have accepted it.
A few really minor issues (decided it was not worth asking for changes before accepting this) - There are a couple of minor typos in the comments (will fix at some point in the future) and I'd suggest running gofmt before submitting PR's (not a big deal but the next commit of this file will contain a few formatting updates).

@GilGil1
Copy link
Contributor Author

GilGil1 commented Dec 23, 2021

Hi Matt,
Thanks a lot,
I sent a PR #575 , if you wish to use. If not I will delete it

MattBrittan added a commit that referenced this pull request Dec 23, 2021
Fix of small typos from PR #574
@MattBrittan
Copy link
Contributor

Thanks @GilGil1 - I have merged this (as you changed a function name I thought it best to do that fast!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants