Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeQL & integer conversion fix #541

Merged
merged 2 commits into from Sep 22, 2021
Merged

CodeQL & integer conversion fix #541

merged 2 commits into from Sep 22, 2021

Conversation

jfcg
Copy link
Contributor

@jfcg jfcg commented Sep 22, 2021

No description provided.

@jfcg
Create codeql-analysis.yml
ab5157e
@jfcg
replace Atoi with ParseUint
be73400 
Incorrect conversion between integer types, discovered by CodeQL
MattBrittan
MattBrittan approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@MattBrittan MattBrittan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change is technically correct (the chance of the existing conversion causing an issue is very slight - a file would need to be manually added to the store folder).

@MattBrittan MattBrittan merged commit 175027d into eclipse:master Sep 22, 2021
This was referenced Jun 5, 2022
Merged
Merged
Open
Merged
This was referenced Jun 18, 2022
Open
Open
Open
Open
Open
Open
Open
Open
@renovate renovate bot mentioned this pull request Jul 19, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattBrittan MattBrittan MattBrittan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfcg @MattBrittan