Use uri.Path instead of uri.Host for UNIX domain socket URLs #540
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows to use proper UNIX socket URIs such as
unix:///var/run/socket.sock
. This format is OK with RFC3986 and used in Docker, for example.Current implementation makes possible only relative paths (like
unix://socket.sock
) and it looks like it does so by accident.Example of how it is parsed by
url.Parse()
: https://play.golang.org/p/OajK5IJX2F9