Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for willRenameFiles/willCreateFiles/willDeleteFiles #823

Open
zulus opened this issue Sep 25, 2023 · 3 comments
Open

Add support for willRenameFiles/willCreateFiles/willDeleteFiles #823

zulus opened this issue Sep 25, 2023 · 3 comments

Comments

@zulus
Copy link
Contributor

zulus commented Sep 25, 2023

As in subject. LSP4E currently only support basic inline refactoring in editor, could also support RefactoringParticipant inside project explorer

zulus added a commit to zulus/lsp4e that referenced this issue Sep 25, 2023
zulus added a commit to zulus/lsp4e that referenced this issue Sep 25, 2023
@angelozerr
Copy link
Contributor

IMHO LSP4E should implement this support because renaming a file is a commons usecase and without this support it can be a nightmare for user.

Imagine that you are coding a Java project and you want to rename a Java file. A lot of files must be updated. Without this willRenameFiles it is not possible.

Advanced ls like gopls, rust anayzer, jdt ls have this support which is working well in vscode but not in eclipse ide.

I am supporting this didRenameFiles for IntelliJ and I think you could use a lot of code that I have written like glob pattern (I have translated all test from vscode about glob pattern and all tests are working now)

If you are interested to use some part of my code and perhaps adapt it for eclipse api please ask me and I will give you some links

@angelozerr
Copy link
Contributor

I forget to mention that I have too implemented didChangeFileWatcher which is too very important

@zulus
Copy link
Contributor Author

zulus commented Apr 5, 2024

I’ll update this patch in couple days. It was required to support lsp refactoring features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants