Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELContextCleaner no longer needed. #8712

Closed
janbartel opened this issue Oct 14, 2022 · 4 comments
Closed

ELContextCleaner no longer needed. #8712

janbartel opened this issue Oct 14, 2022 · 4 comments
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@janbartel
Copy link
Contributor

jetty_10

The o.e.j.servlet.listener.ELContextCleaner class is no longer needed, as the class that it attempts to clean up for javax.el.BeanELResolver no longer contains a static field called properties that was the problem.

@janbartel janbartel added the Bug For general bugs on Jetty side label Oct 14, 2022
@janbartel janbartel self-assigned this Oct 14, 2022
janbartel added a commit that referenced this issue Oct 14, 2022
@janbartel
Copy link
Contributor Author

Note to self: when merging through to jetty-12, remember to modify ee9 ELContextCleaner to also ignore NoSuchFieldExceptions to prevent lines like this during shutdown:

JettyShutdownThread: Not cleaning cached beans: no such field javax.el.BeanELResolver.properties

@olamy
Copy link
Member

olamy commented Oct 14, 2022

Note to self: when merging through to jetty-12, remember to modify ee9 ELContextCleaner to also ignore NoSuchFieldExceptions to prevent lines like this during shutdown:

why not simply remove it in jetty-12?

JettyShutdownThread: Not cleaning cached beans: no such field javax.el.BeanELResolver.properties

@janbartel
Copy link
Contributor Author

@olamy I've removed it already from ee10, but I figure I need to keep it consistent for ee8 and ee9.

@janbartel
Copy link
Contributor Author

Merged through to jetty-12.

sebastien-belin-adp pushed a commit to adaptris/interlok that referenced this issue Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

No branches or pull requests

2 participants