Skip to content

Indicate units of HttpClient properties #8591

Closed
@cowwoc

Description

@cowwoc
Contributor

Jetty version(s) 11.0.1

Enhancement Description

For example, I assume that HttpClient.setRequestBufferSize() and HttpClient.setResponseBufferSize() refer to a value in bytes but it would be helpful for the Javadoc to state this explicitly. Alternatively, rename the parameter name from say requestBufferSize to requestBufferSizeInBytes.

Activity

sbordet

sbordet commented on Sep 15, 2022

@sbordet
Contributor

Care to contribute a pull request? Against jetty-10.0.x, we will merge forward. Thanks!

added 3 commits that reference this issue on Oct 18, 2022

Fixes jetty#8591: Indicate units of HttpClient properties.

46d0441

Fixes jetty#8591: Indicate units of HttpClient properties.

12ae588

Fixes jetty#8591: Indicate units of HttpClient properties.

7e11915
cowwoc

cowwoc commented on Oct 18, 2022

@cowwoc
ContributorAuthor

Done

joakime

joakime commented on Oct 18, 2022

@joakime
Contributor

Might want to link the PR here.
Looks like you went above and beyond with PRs for all three active branches.
We really only need 10.0.x and we'll merge forward.

cowwoc

cowwoc commented on Oct 18, 2022

@cowwoc
ContributorAuthor

@joakime Here you go: #8728

Sorry for the other PRs. I'll close the extra ones.

added a commit that references this issue on Feb 20, 2024

Jetty 10 - jetty#8591: Indicate units of HttpClient properties (jetty…

481c801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @joakime@sbordet@cowwoc

        Issue actions

          Indicate units of HttpClient properties · Issue #8591 · jetty/jetty.project