Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #8578 - getRequestURL can append "null" if getRequestURI is unspecified in an authority-form request-target #8580

Merged
merged 2 commits into from Sep 13, 2022

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Sep 9, 2022

When working with CONNECT headers, the old implementation of HttpURI.getPath() would return the authority component.
The changes in #8014 broke this backward compatibility behavior, causing unintended behaviors on HttpServletRequest.getRequestURL() and HttpServletRequest.getRequestURI().

Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

…URI when working with CONNECT method

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime changed the title Issue #8578 - restore backward compat of getRequestURL and getRequestURI when working with CONNECT method Issue #8578 - getRequestURL can append "null" if getRequestURI is unspecified (like with CONNECT method) Sep 13, 2022
@joakime joakime changed the title Issue #8578 - getRequestURL can append "null" if getRequestURI is unspecified (like with CONNECT method) Issue #8578 - getRequestURL can append "null" if getRequestURI is unspecified in an authority-form request-target Sep 13, 2022
@joakime joakime merged commit 2a49f86 into jetty-10.0.x Sep 13, 2022
@joakime joakime deleted the fix/jetty-10.0.x-proxy-rewrite-null-uri branch September 13, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants