Fix test-distribution classpath re resolver #8187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As currently it seems mixed versions of resolver artifacts are present on classpath. Resolver 1.8.0 introduces a binary breakage. Anyway, this fixes the thing, as impl was actually coming in as transitive dep of maven-resolver-provider, that is NOT the same version as the rest of resolver dependencies. Relying on transitive while fixing other versions is wrong.
Merged
And add exclusion to banned dependency, that is used when running in SISU container.
joakime
reviewed
Jun 21, 2022
| <artifactId>maven-resolver-impl</artifactId> | ||
| <version>${maven.resolver.version}</version> | ||
| <exclusions> | ||
| <!-- Used when running in SISU container to manage beans lifecycle (of locking factories) --> |
There was a problem hiding this comment.
I don't understand this comment.
There was a problem hiding this comment.
Sisu container is able to manage lifecycle, and on container shutdown will invoke this method. For your case is not needee, as you craft resolver manually, but also do not use any special kind of named locks that would require this cleanup (you use defaults).
|
Strange, this PR now made module far-far before change to break and seems completely unrelated |
|
FTR, created eclipse/sisu.inject#58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently it seems mixed versions of resolver artifacts are
present on classpath. Resolver 1.8.0 introduces a binary
breakage against 1.6.x.
Updated to bugfix 1.8.1 resolver
Anyway, this fixes the thing, as impl was actually coming in
as transitive dep of maven-resolver-provider, that is NOT
the same version as the rest of resolver dependencies.
Relying on transitive while fixing other versions is wrong.