Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetty.sh does not read JAVA_OPTIONS anymore #8152

Closed
fanf opened this issue Jun 9, 2022 · 2 comments · Fixed by #8153
Closed

jetty.sh does not read JAVA_OPTIONS anymore #8152

fanf opened this issue Jun 9, 2022 · 2 comments · Fixed by #8153
Labels
Bug For general bugs on Jetty side

Comments

@fanf
Copy link
Contributor

fanf commented Jun 9, 2022

Jetty version(s)

Jetty 10.x since commit c898666, ie

git tag --contains=c89866682c14ca1da0ce482eeca0953375b25da8
jetty-10.0.8
jetty-10.0.9
jetty-11.0.8
jetty-11.0.9

Java version/vendor (use: java -version)

Any

OS type/version

Any

Description

Since commit c898666, JAVA_OPTIONS is not read anywhere in jetty.sh script.
I believe the goal of the refactoring was to add JETTY_SYS_PROPS and then add JAVA_OPTIONS in RUN_ARGS, but it was not done

@fanf fanf added the Bug For general bugs on Jetty side label Jun 9, 2022
fanf added a commit to fanf/jetty.project that referenced this issue Jun 9, 2022
fanf added a commit to fanf/jetty.project that referenced this issue Jun 9, 2022
@joakime
Copy link
Contributor

joakime commented Jun 9, 2022

The removal of JAVA_OPTIONS was because of the nature of how configurations could fork a JVM.
Those options would not carry over to a configuration that would fork the JVM.

The changes in jetty.sh reflect this, and an effort to build the true command line based on your Configuration.
This means using the exec module in your ${jetty.base}/start.d/exec.ini and including any previous JAVA_OPTIONS there.

@fanf
Copy link
Contributor Author

fanf commented Jun 9, 2022

OK, thanks for the information. I'm not sure it will work for us, since we are sourcing external config files to get the option list, but I will look at the doc now that I know the entry point. Thanks for the pointer.

joakime pushed a commit that referenced this issue Jun 22, 2022
Co-authored-by: Francois @fanf42 Armand <francois.armand@normation.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants