Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change-dependabot-interval-to-monthly #8140

Merged

Conversation

olamy
Copy link
Member

@olamy olamy commented Jun 8, 2022

No description provided.

@olamy olamy added the bad-idea label Jun 8, 2022
@olamy olamy requested a review from joakime June 8, 2022 03:42
gregw
gregw previously approved these changes Jun 8, 2022
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't solve anything, in fact it just makes for more work, more time spent, and harsher demands on the CI system.

Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the schedule from 9.4.x, we should have it be scheduleless.

Set 10.0.x and 11.0.x to monthly.
See if you can trigger it on the first of each month. (see if the "monthly" literal is on the first of each month)

@joakime
Copy link
Contributor

joakime commented Jun 8, 2022

It would be keen if we could setup a schedule to be "the first Saturday of each month", that way the rush of CI builds will done over the weekend.

Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to adjust the open-pull-requests-limit for the rush of PRs arriving monthly now.

.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
@joakime
Copy link
Contributor

joakime commented Jun 8, 2022

Darn, looks like schedule.interval is a required field.

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#scheduleinterval

Set them all to ...

    schedule:
      interval: "monthly"
      day: "saturday"
      time: "02:00"

@joakime
Copy link
Contributor

joakime commented Jun 8, 2022

Our monthly runs will result in (on average) 67.2 PRs. (calculation: (5.8 + 6.8 + 4.2) * 4)
Of which there's 2 (or 3) builds per PR.
So 134 to 201 builds.
Yeah, triggering these builds early on Saturday makes sense.

@olamy
Copy link
Member Author

olamy commented Jun 8, 2022

Our monthly runs will result in (on average) 67.2 PRs. (calculation: (5.8 + 6.8 + 4.2) * 4) Of which there's 2 (or 3) builds per PR. So 134 to 201 builds. Yeah, triggering these builds early on Saturday makes sense.

open-pull-requests-limit: 20.
not sure how blocker is that. so that may delay a lot of updates :)

@joakime
Copy link
Contributor

joakime commented Jun 8, 2022

open-pull-requests-limit: 20.
not sure how blocker is that. so that may delay a lot of updates :)

Check the comments on the PR, I posted some suggestions on new values for these.

@olamy
Copy link
Member Author

olamy commented Jun 9, 2022

@joakime I need your approval as you requested changes. thanks

@olamy
Copy link
Member Author

olamy commented Jun 9, 2022

all good as the PR has even proper labels 🤣 😜.
I will merge it.

@olamy olamy merged commit 0d13cbe into jetty-10.0.x Jun 9, 2022
@olamy olamy deleted the jetty-10.0.x-change-dependabot-interval-to-monthly branch June 9, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants