Improve cleanup of deflater/inflater pools for PerMessageDeflateExtension #8134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lorban
previously requested changes
Jun 7, 2022
...mmon/src/main/java/org/eclipse/jetty/websocket/core/internal/PerMessageDeflateExtension.java
Outdated
Show resolved
Hide resolved
sbordet
requested changes
Jun 7, 2022
...ebsocket/websocket-core-common/src/main/java/org/eclipse/jetty/websocket/core/Extension.java
Show resolved
Hide resolved
gregw
reviewed
Jun 7, 2022
...socket-core-common/src/main/java/org/eclipse/jetty/websocket/core/internal/FrameFlusher.java
Show resolved
Hide resolved
...mmon/src/main/java/org/eclipse/jetty/websocket/core/internal/PerMessageDeflateExtension.java
Outdated
Show resolved
Hide resolved
...core-common/src/main/java/org/eclipse/jetty/websocket/core/internal/TransformingFlusher.java
Show resolved
Hide resolved
...core-common/src/main/java/org/eclipse/jetty/websocket/core/internal/TransformingFlusher.java
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
requested changes
Jun 8, 2022
...cket-core-common/src/main/java/org/eclipse/jetty/websocket/core/internal/ExtensionStack.java
Show resolved
Hide resolved
...ebsocket/websocket-core-common/src/main/java/org/eclipse/jetty/websocket/core/Extension.java
Outdated
Show resolved
Hide resolved
|
Do we want this in Jetty 10.0.10 release? |
|
@joakime yes this should be in the |
lachlan-roberts
added this to In progress
in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
via automation
joakime
moved this from In progress
to Review in progress
in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
joakime
added
the
Sponsored
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
approved these changes
Jun 8, 2022
...ebsocket/websocket-core-common/src/main/java/org/eclipse/jetty/websocket/core/Extension.java
Outdated
Show resolved
Hide resolved
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
automation
moved this from Review in progress
to Reviewer approved
Jun 8, 2022
gregw
reviewed
Jun 10, 2022
| @@ -44,7 +44,6 @@ public class FrameFlusher extends IteratingCallback | |||
| { | |||
| public static final Frame FLUSH_FRAME = new Frame(OpCode.BINARY); | |||
| private static final Logger LOG = LoggerFactory.getLogger(FrameFlusher.class); | |||
| private static final Throwable CLOSED_CHANNEL = new ClosedChannelException(); | |||
There was a problem hiding this comment.
@lachlan-roberts as discussed on chat.... I think we can keep this static sentinael and just use the constructor that avoids suppressed exceptions and a stacktrace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompressionPoolvia JMX.PermessageDeflateExtensionshould release deflaters.FrameFlusher.