Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to configure exitVm on ShutdownMonitor from System properties #8088

Closed
janbartel opened this issue Jun 1, 2022 · 0 comments · Fixed by #8133 or #8089
Closed

Add option to configure exitVm on ShutdownMonitor from System properties #8088

janbartel opened this issue Jun 1, 2022 · 0 comments · Fixed by #8133 or #8089
Assignees
@janbartel
Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement
Projects
Jetty 9.4.47 - 🧊 FROZEN 🥶 Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶

Comments

@janbartel
Copy link
Contributor

janbartel commented Jun 1, 2022 •
edited by joakime

9.4+

Add a System property like STOP.EXIT=[true|false] to enable configuration of ShutdownMonitor exitVm from the command line.
@janbartel janbartel added Enhancement Sponsored This issue affects a user with a commercial support agreement labels Jun 1, 2022
@janbartel janbartel self-assigned this Jun 1, 2022
@janbartel janbartel added this to To do in Jetty 9.4.47 - 🧊 FROZEN 🥶 via automation Jun 1, 2022
janbartel added a commit that referenced this issue Jun 1, 2022
@janbartel
Issue #8088 Add STOP.EXIT System property to configure ShutdownMonito…
74c7985 
…r.exitVM
@janbartel janbartel mentioned this issue Jun 1, 2022
Merged
@joakime joakime moved this from To do to In progress in Jetty 9.4.47 - 🧊 FROZEN 🥶 Jun 1, 2022
janbartel added a commit that referenced this issue Jun 7, 2022
@janbartel
Issue #8088 Add STOP.EXIT System property to configure ShutdownMonito…
208b150 
…r.exitVm (#8089)

* Issue #8088 Add STOP.EXIT System property to configure ShutdownMonitor.exitVM

* Ensure missing STOP.EXIT doesn't override default exitVm=true

* Disable another test
janbartel added a commit that referenced this issue Jun 7, 2022
@janbartel
Issue #8088 Add STOP.EXIT System property to configure ShutdownMonito…
183b3c0 
…r.exitVm (#8089)

* Issue #8088 Add STOP.EXIT System property to configure ShutdownMonitor.exitVM

* Ensure missing STOP.EXIT doesn't override default exitVm=true

* Disable another test
@joakime joakime added this to To do in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 via automation Jun 7, 2022
@joakime joakime moved this from In progress to Done in Jetty 9.4.47 - 🧊 FROZEN 🥶 Jun 7, 2022
@joakime joakime moved this from To do to Review in progress in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 Jun 7, 2022
This was linked to pull requests Jun 7, 2022
Issue #8088 Add STOP.EXIT System property to configure ShutdownMonitor.exitVm #8133
Merged
Issue #8088 Add STOP.EXIT System property to configure ShutdownMonitor.exitVm #8089
Merged
@joakime joakime moved this from Review in progress to In progress in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 Jun 7, 2022
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 automation moved this from In progress to Done Jun 8, 2022
janbartel added a commit that referenced this issue Jun 8, 2022
@janbartel
Issue #8088 Add STOP.EXIT System property to configure ShutdownMonito…
d725855 
…r.exitVm (#8133)

* Issue #8088 Add STOP.EXIT System property to configure ShutdownMonitor.exitVm (#8089)

* Issue #8088 Add STOP.EXIT System property to configure ShutdownMonitor.exitVM

* Ensure missing STOP.EXIT doesn't override default exitVm=true

* Disable another test

* Disable test that might not work, depending on test execution order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbartel janbartel

Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
  
Done
Jetty 9.4.47 - 🧊 FROZEN 🥶
  
Done
Milestone
No milestone
1 participant
@janbartel