Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #7837 - Fix StatisticsHandler in the case a Handler throws exception. #7953

Merged
merged 3 commits into from May 6, 2022
Merged

Issue #7837 - Fix StatisticsHandler in the case a Handler throws exception. #7953

merged 3 commits into from May 6, 2022

Conversation

lachlan-roberts
Copy link
Contributor

@lachlan-roberts lachlan-roberts commented May 4, 2022 •
edited

merge of #7837 to jetty 10.0.x branch

@lachlan-roberts
Fix StatisticsHandler in the case a Handler throws exception.
39c4784 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts requested a review from gregw May 4, 2022 06:05
gregw
gregw previously approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but again CI failed?

@olamy
Copy link
Member

olamy commented May 4, 2022

This looks fine, but again CI failed?

I'm reproducing locally

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:testCompile (default-testCompile) on project jetty-server: Compilation failure: Compilation failure: 
[ERROR] /Volumes/workspace/dev/sources/open-sources/jetty/jetty.project/jetty-server/src/test/java/org/eclipse/jetty/server/handler/StatisticsHandlerTest.java:[37,34] cannot find symbol
[ERROR]   symbol:   class StacklessLogging
[ERROR]   location: package org.eclipse.jetty.util.log
[ERROR] /Volumes/workspace/dev/sources/open-sources/jetty/jetty.project/jetty-server/src/test/java/org/eclipse/jetty/server/handler/StatisticsHandlerTest.java:[450,14] cannot find symbol
[ERROR]   symbol:   class StacklessLogging
[ERROR]   location: class org.eclipse.jetty.server.handler.StatisticsHandlerTest
[ERROR] /Volumes/workspace/dev/sources/open-sources/jetty/jetty.project/jetty-server/src/test/java/org/eclipse/jetty/server/handler/StatisticsHandlerTest.java:[450,45] cannot find symbol
[ERROR]   symbol:   class StacklessLogging
[ERROR]   location: class org.eclipse.jetty.server.handler.StatisticsHandlerTest
[ERROR] -> [Help 1]

@joakime joakime changed the title Fix StatisticsHandler in the case a Handler throws exception. Issue #7837 - Fix StatisticsHandler in the case a Handler throws exception. May 4, 2022
@joakime
Issue #7837 - fix compilation error
fcd0222 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime
Copy link
Contributor

joakime commented May 4, 2022

I fixed the compilation error - fcd0222

@lachlan-roberts lachlan-roberts merged commit 838e3a3 into jetty-10.0.x May 6, 2022
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-statsHandlerThrows branch May 6, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lachlan-roberts @olamy @joakime @gregw