Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct requestlog formatString commented default #7929

Closed
prenagha opened this issue Apr 27, 2022 · 3 comments · Fixed by #7931
Closed

Correct requestlog formatString commented default #7929

prenagha opened this issue Apr 27, 2022 · 3 comments · Fixed by #7931
Assignees
@lachlan-roberts
Labels
Documentation
Projects
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 Jetty 12.0.ALPHA1

Comments

@prenagha
Copy link
Contributor

Jetty version(s)
10.0.9

Java version/vendor
17 Coretto

OS type/version
Mac 12.3.1

Description
Align the commented default jetty.requestlog.formatString mentioned in the requestlog.ini with the default used in the code (CustomRequestLog).
Currently the comment refers to a %B that isn't used by the code nor is mentioned as being valid by the documentation.
Also adjust the %a parameter option to indicate which form the code uses.

How to reproduce?
Add the requestlog module to Jetty, observe the commented defaults in requestlog.ini
@prenagha prenagha added the Bug For general bugs on Jetty side label Apr 27, 2022
@prenagha
Copy link
Contributor Author

PR in a moment

prenagha added a commit to prenagha/jetty.project that referenced this issue Apr 27, 2022
@prenagha
Fix jetty#7929 requestlog format string commented default
1369693 
Signed-off-by: Padraic Renaghan <padraic@renaghan.com>
@joakime joakime added this to To do in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 via automation Apr 28, 2022
@joakime joakime moved this from To do to Review in progress in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 Apr 28, 2022
@joakime joakime linked a pull request Apr 28, 2022 that will close this issue
Fix #7929 requestlog format string commented default #7931
Merged
@joakime joakime added Documentation and removed Bug For general bugs on Jetty side labels Apr 28, 2022
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 automation moved this from Review in progress to Done Apr 28, 2022
lachlan-roberts added a commit that referenced this issue Apr 28, 2022
@lachlan-roberts
Merge pull request #7931 from prenagha/jetty-10.0.x
e8c3f08 
Fix #7929 requestlog format string commented default
@gregw gregw added this to To do in Jetty 12.0.ALPHA1 via automation Apr 28, 2022
@gregw
Copy link
Contributor

gregw commented Apr 28, 2022

@lachlan-roberts needs to be merged to 12

@gregw gregw reopened this Apr 28, 2022
Jetty 12.0.ALPHA1 automation moved this from To do to In progress Apr 28, 2022
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 automation moved this from Done to In progress Apr 28, 2022
lachlan-roberts pushed a commit that referenced this issue Apr 28, 2022
@prenagha @lachlan-roberts
Fix #7929 requestlog format string commented default
24c0e9d 
Signed-off-by: Padraic Renaghan <padraic@renaghan.com>
@lachlan-roberts
Copy link
Contributor

done with 24c0e9d

Jetty 12.0.ALPHA1 automation moved this from In progress to Done Apr 28, 2022
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 automation moved this from In progress to Done Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Documentation
Projects
No open projects
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
  
Done
Jetty 12.0.ALPHA1
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #7929 requestlog format string commented default prenagha/jetty.project
4 participants
@gregw @joakime @prenagha @lachlan-roberts