Skip to content

Correct requestlog formatString commented default #7929

Closed
@prenagha

Description

@prenagha

Jetty version(s)
10.0.9

Java version/vendor
17 Coretto

OS type/version
Mac 12.3.1

Description
Align the commented default jetty.requestlog.formatString mentioned in the requestlog.ini with the default used in the code (CustomRequestLog).
Currently the comment refers to a %B that isn't used by the code nor is mentioned as being valid by the documentation.
Also adjust the %a parameter option to indicate which form the code uses.

How to reproduce?
Add the requestlog module to Jetty, observe the commented defaults in requestlog.ini

Activity

prenagha

prenagha commented on Apr 27, 2022

@prenagha
ContributorAuthor

PR in a moment

added a commit that references this issue on Apr 27, 2022

Fix jetty#7929 requestlog format string commented default

1369693
added and removed
BugFor general bugs on Jetty side
on Apr 28, 2022
added a commit that references this issue on Apr 28, 2022

Merge pull request #7931 from prenagha/jetty-10.0.x

e8c3f08
gregw

gregw commented on Apr 28, 2022

@gregw
Contributor

@lachlan-roberts needs to be merged to 12

reopened this on Apr 28, 2022
added a commit that references this issue on Apr 28, 2022

Fix #7929 requestlog format string commented default

24c0e9d
lachlan-roberts

lachlan-roberts commented on Apr 28, 2022

@lachlan-roberts
Contributor

done with 24c0e9d

1 remaining item

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @gregw@joakime@prenagha@lachlan-roberts

    Issue actions

      Correct requestlog formatString commented default · Issue #7929 · jetty/jetty.project