Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PathMappings.asPathSpec does not allow root ServletPathSpec #7918

Closed
gregw opened this issue Apr 26, 2022 · 2 comments · Fixed by #7920 or #7919
Closed

PathMappings.asPathSpec does not allow root ServletPathSpec #7918

gregw opened this issue Apr 26, 2022 · 2 comments · Fixed by #7920 or #7919
Labels
Bug For general bugs on Jetty side
Projects
Jetty 12.0.ALPHA1 Jetty 9.4.47 - 🧊 FROZEN 🥶 Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶

Comments

@gregw
Copy link
Contributor

gregw commented Apr 26, 2022

Jetty version(s)
all

Description

The ServletPathSpec of "" (empty string) is the root only match. This is not allowed by PathMappings.asPathSpec, which can prevent code that does not explicitly use ServletPathSpec from matching root.
@gregw gregw added the Bug For general bugs on Jetty side label Apr 26, 2022
@gregw gregw added this to To do in Jetty 12.0.ALPHA1 via automation Apr 26, 2022
@gregw gregw added this to To do in Jetty 9.4.47 - 🧊 FROZEN 🥶 via automation Apr 26, 2022
@gregw gregw added this to To do in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 via automation Apr 26, 2022
gregw added a commit that referenced this issue Apr 26, 2022
@gregw
Fix #7918 Root path spec
9c8f99e 
Handle root pathspec in PathMappings.asPathSpec

Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Apr 26, 2022
@gregw
Fix #7918 Root path spec
1286385 
Handle root pathspec in PathMappings.asPathSpec

Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Apr 26, 2022
@gregw
Fix #7918 Root path spec
4fe55e2 
cleaner logic

Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Apr 26, 2022
@gregw
Fix #7918 Root path spec
2f1e6d2 
cleaner logic

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw closed this as completed in e12d5d5 Apr 26, 2022
Jetty 12.0.ALPHA1 automation moved this from To do to Done Apr 26, 2022
Jetty 9.4.47 - 🧊 FROZEN 🥶 automation moved this from To do to Done Apr 26, 2022
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 automation moved this from To do to Done Apr 26, 2022
gregw added a commit that referenced this issue Apr 26, 2022
@gregw
Jetty 10 7918 root pathspec (#7920)
daee55f 
Fix #7918 Root path spec
Handle root pathspec in PathMappings.asPathSpec
Introduce protected asPathSpec to allow for extensibility

Signed-off-by: Greg Wilkins <gregw@webtide.com>
This was linked to pull requests Apr 26, 2022
Jetty 10 7918 root pathspec #7920
Merged
Fix #7918 Root path spec #7919
Merged
@gregw
Copy link
Contributor Author

gregw commented Apr 26, 2022

merged to 10,11 & 12. Waiting for build for 9

@gregw gregw reopened this Apr 26, 2022
Jetty 12.0.ALPHA1 automation moved this from Done to In progress Apr 26, 2022
Jetty 9.4.47 - 🧊 FROZEN 🥶 automation moved this from Done to In progress Apr 26, 2022
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 automation moved this from Done to In progress Apr 26, 2022
@gregw gregw moved this from In progress to Done in Jetty 12.0.ALPHA1 Apr 26, 2022
@gregw gregw moved this from In progress to Done in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 Apr 26, 2022
@gregw gregw moved this from In progress to Reviewer approved in Jetty 9.4.47 - 🧊 FROZEN 🥶 Apr 26, 2022
joakime pushed a commit that referenced this issue Apr 26, 2022
@gregw
Fix #7918 Root path spec (#7919)
6945f53 
* Fix #7918 Root path spec

Handle root pathspec in PathMappings.asPathSpec

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@joakime joakime moved this from Reviewer approved to Done in Jetty 9.4.47 - 🧊 FROZEN 🥶 Apr 26, 2022
@joakime
Copy link
Contributor

joakime commented Apr 26, 2022

Fully merged now.

@joakime joakime closed this as completed Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
  
Done
Jetty 12.0.ALPHA1
  
Done
Jetty 9.4.47 - 🧊 FROZEN 🥶
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jetty 10 7918 root pathspec jetty/jetty.project
Fix #7918 Root path spec jetty/jetty.project
2 participants
@gregw @joakime