Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default servlet drops first accept-encoding header if there is more than one. #7863

Closed
markslater opened this issue Apr 8, 2022 · 1 comment · Fixed by #7864 or #7871
Closed

Default servlet drops first accept-encoding header if there is more than one. #7863

markslater opened this issue Apr 8, 2022 · 1 comment · Fixed by #7864 or #7871
Labels
Bug For general bugs on Jetty side
Projects
Jetty 9.4.47 - 🧊 FROZEN 🥶 Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶

Comments

@markslater
Copy link
Contributor

Jetty version(s)
11.0.9

Java version/vendor (use: java -version)
N/A

OS type/version
N/A

Description
When DefaultServlet handles a request with multiple accept-encoding headers, it attempts to combine their values, but it drops the value of the first header (and produces a value with a leading comma).

How to reproduce?
Test case to follow.
@markslater markslater added the Bug For general bugs on Jetty side label Apr 8, 2022
markslater added a commit to markslater/jetty.project that referenced this issue Apr 8, 2022
@markslater
jetty#7863 Include value of first accept-encoding header where multip…
f17beca 
…le accept-encoding headers are given.

Signed-off-by: markslater <mark.slater@mail.com>
markslater added a commit to markslater/jetty.project that referenced this issue Apr 10, 2022
@markslater
jetty#7863 Include value of first accept-encoding header where multip…
572eda2 
…le accept-encoding headers are given.

Signed-off-by: markslater <mark.slater@mail.com>
joakime pushed a commit that referenced this issue Apr 11, 2022
@markslater
#7863 Include value of first accept-encoding header where multiple ac…
8bcb842 
…cept-encoding headers are given. (#7864)

Signed-off-by: markslater <mark.slater@mail.com>
joakime pushed a commit that referenced this issue Apr 11, 2022
@markslater @joakime
#7863 Include value of first accept-encoding header where multiple ac…
5bacb46 
…cept-encoding headers are given. (#7864)

Signed-off-by: markslater <mark.slater@mail.com>
This was linked to pull requests Apr 11, 2022
#7863 Include value of first accept-encoding header when there is more then one #7864
Merged
#7863 Include value of first accept-encoding header where multiple accept-encoding headers are given #7871
Merged
@joakime joakime added this to To do in Jetty 9.4.47 - 🧊 FROZEN 🥶 via automation Apr 11, 2022
@joakime joakime added this to To do in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 via automation Apr 11, 2022
@joakime joakime moved this from To do to Review in progress in Jetty 9.4.47 - 🧊 FROZEN 🥶 Apr 11, 2022
joakime added a commit that referenced this issue Apr 27, 2022
@joakime @markslater
#7863 Include value of first accept-encoding header where multiple ac…
7d6693c 
…cept-encoding headers are given. (#7864) (#7871)

Signed-off-by: markslater <mark.slater@mail.com>

Co-authored-by: markslater <mark.slater@mail.com>
@joakime joakime moved this from Review in progress to Done in Jetty 9.4.47 - 🧊 FROZEN 🥶 May 11, 2022
@joakime
Copy link
Contributor

joakime commented May 11, 2022

All merged into jetty-9.4.x and jetty-10.0.x+

@joakime joakime closed this as completed May 11, 2022
joakime pushed a commit that referenced this issue Oct 6, 2022
@markslater @joakime
#7863 Include value of first accept-encoding header where multiple ac…
1f844e8 
…cept-encoding headers are given. (#7864)

Signed-off-by: markslater <mark.slater@mail.com>
@olamy olamy mentioned this issue Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
  
Done
Jetty 9.4.47 - 🧊 FROZEN 🥶
  
Done
Milestone
No milestone
2 participants
@joakime @markslater