HTTP/3 QPACK - do not expect section ack for zero required insert count #7802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
requested changes
May 12, 2022
| { | ||
| // Encode a header with only a value contained in the static table. | ||
| ByteBuffer buffer = encode(_encoder, 0, toMetaData("GET", "/", "http")); | ||
| System.err.println(BufferUtil.toDetailString(buffer)); |
| // Parsing a section ack instruction on the encoder when we are not expecting it should result in QPACK_DECODER_STREAM_ERROR. | ||
| SectionAcknowledgmentInstruction instruction = new SectionAcknowledgmentInstruction(0); | ||
| ByteBuffer instructionBuffer = toBuffer(instruction); | ||
| QpackException error = assertThrows(QpackException.class, () -> _encoder.parseInstructions(instructionBuffer)); |
There was a problem hiding this comment.
You want to test for QpackException.StreamException here to be sure it's not a SESSION error.
There was a problem hiding this comment.
It is a SessionException and thats what I would expect it to be. The rfc says it must be treated "as a connection error".
I have added this check to the test case.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datatracker.ietf.org/doc/html/draft-ietf-quic-qpack-21#section-4.4.1