Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPv6 format #6860

Closed
gregw opened this issue Sep 17, 2021 · 0 comments · Fixed by #6861 or #6885
Closed

IPv6 format #6860

gregw opened this issue Sep 17, 2021 · 0 comments · Fixed by #6861 or #6885
Assignees
@gregw
Labels
Bug For general bugs on Jetty side High Priority Sponsored This issue affects a user with a commercial support agreement
Projects
Jetty 9.4.44 FROZEN Jetty 10.0.7/11.0.7 FROZEN

Comments

@gregw
Copy link
Contributor

gregw commented Sep 17, 2021

Jetty version(s)
9.4.x

Description

After fix #5128 for #5079, it is no longer possible to configure how an IPv6 address is returned from the servlet-api. Some applications are expecting the address to be bracketed, others without brackets and yet others might depend on receiving the address exactly how it is received. This is causing problems on PAAS/SAAS providers that cannot modify the applications. We need a per context configuration to control IPv6 format.
@gregw gregw added High Priority Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement labels Sep 17, 2021
@gregw gregw added this to To do in Jetty 9.4.44 FROZEN via automation Sep 17, 2021
@gregw gregw self-assigned this Sep 17, 2021
gregw added a commit that referenced this issue Sep 17, 2021
@gregw
Fix #6860 IPv6 Format
79395c5 
Fix #6860 IPv6 format by adding a per context configuration.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw mentioned this issue Sep 17, 2021
Merged
gregw added a commit that referenced this issue Sep 17, 2021
@gregw
Fix #6860 IPv6 Format
316b4bf 
updates from review

Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Sep 19, 2021
@gregw
Fix #6860 IPv6 Format
11720f7 
unit test and fixes

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw added this to To do in Jetty 10.0.7/11.0.7 FROZEN via automation Sep 19, 2021
gregw added a commit that referenced this issue Sep 19, 2021
@gregw
Fix #6860 IPv6 Format
38192fc 
fix style

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@joakime joakime moved this from To do to In progress in Jetty 9.4.44 FROZEN Sep 20, 2021
@joakime joakime linked a pull request Sep 20, 2021 that will close this issue
Fix #6860 IPv6 Format #6861
Merged
@joakime joakime moved this from To do to In progress in Jetty 10.0.7/11.0.7 FROZEN Sep 20, 2021
gregw added a commit that referenced this issue Sep 21, 2021
@gregw @lachlan-roberts
Fix #6860 IPv6 Format (#6861)
9b3fb19 
Fix #6860 IPv6 format by adding an extensible HttpChannel method

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Co-authored-by: Lachlan Roberts <lachlan@webtide.com>
gregw added a commit that referenced this issue Sep 21, 2021
@gregw
Fix #6860 IPv6 Format (#6861)
6c7472e 
Fix #6860 IPv6 format by adding an extensible HttpChannel method

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Co-authored-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
# Conflicts:
#	jetty-server/src/main/java/org/eclipse/jetty/server/HttpChannel.java
#	jetty-server/src/main/java/org/eclipse/jetty/server/Request.java
#	jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java
#	jetty-server/src/test/java/org/eclipse/jetty/server/RequestTest.java
@gregw gregw mentioned this issue Sep 21, 2021
Merged
Jetty 9.4.44 FROZEN automation moved this from In progress to Done Sep 22, 2021
Jetty 10.0.7/11.0.7 FROZEN automation moved this from In progress to Done Sep 22, 2021
gregw added a commit that referenced this issue Sep 22, 2021
@gregw @lachlan-roberts
Fix #6860 IPv6 Format (#6861) (#6885)
9a14de0 
Fix #6860 IPv6 format by adding an extensible HttpChannel method

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Co-authored-by: Lachlan Roberts <lachlan@webtide.com>
gregw added a commit that referenced this issue Sep 23, 2021
@gregw
Fix #6860 IPv6 Format (#6861)
72f3479 
Fix #6860 IPv6 format by adding an extensible HttpChannel method

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Co-authored-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
# Conflicts:
#	jetty-server/src/main/java/org/eclipse/jetty/server/HttpChannel.java
#	jetty-server/src/main/java/org/eclipse/jetty/server/Request.java
#	jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java
#	jetty-server/src/test/java/org/eclipse/jetty/server/RequestTest.java
gregw added a commit that referenced this issue Sep 23, 2021
@gregw
Fix #6860 IPv6 Format (#6861)
6646405 
Fix #6860 IPv6 format by adding an extensible HttpChannel method

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Co-authored-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
# Conflicts:
#	jetty-server/src/main/java/org/eclipse/jetty/server/HttpChannel.java
#	jetty-server/src/main/java/org/eclipse/jetty/server/Request.java
#	jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java
#	jetty-server/src/test/java/org/eclipse/jetty/server/RequestTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
Bug For general bugs on Jetty side High Priority Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 10.0.7/11.0.7 FROZEN
Done
Jetty 9.4.44 FROZEN
Done
Milestone
No milestone
1 participant
@gregw